Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zm-ews-stub jar version #88

Merged
merged 1 commit into from
Feb 9, 2022
Merged

update zm-ews-stub jar version #88

merged 1 commit into from
Feb 9, 2022
+2 −2

Conversation

inpati
Copy link
Contributor

@inpati inpati commented Feb 7, 2022 •
edited
Loading

Updated zm-zcs-lib ivy.xml and pkg-builder.pl, changed zm-ews-stub jar revision from 2.0 to 3.0.
This change is necessary as whenever we make changes in zm-ews-stub library we have to updated it's revision.

This changes shall be reviewed with old changes for zcs-4452

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

BhavinBathani
BhavinBathani approved these changes Feb 9, 2022
View reviewed changes
Copy link

@BhavinBathani BhavinBathani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BhavinBathani
Copy link

BhavinBathani commented Feb 9, 2022 •
edited
Loading

Some additional thumb rules needs to be followed for commit message and branch-name:

  • Commit message** Started with branch/issue name** Must be clear and to-the-point describing technical summery about change-set.

  • Make sure branch names should be prefixed with issue-type.
    Following are some examples for branch names:** feature/PREAPPS-0000** bugfix/PREAPPS-0000** hotfix/PREAPPS-0000** release/PREAPPS-0000

[This applies to other relevant PRs as well]

zimsuchitgupta
zimsuchitgupta approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@zimsuchitgupta zimsuchitgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inpati inpati merged commit b014a53 into develop Feb 9, 2022
inpati added a commit that referenced this pull request Feb 10, 2022
@inpati
update zm-ews-stub jar version for zm-zcs-lib repo (#88)
63b3a96 
Squash and Merge changes for ZCS-4552
dasiyogesh pushed a commit that referenced this pull request Apr 12, 2022
@inpati @umagmrit
update zm-ews-stub jar version for zm-zcs-lib repo (#88)
b8b5276 
Squash and Merge changes for ZCS-4552
dasiyogesh pushed a commit that referenced this pull request Apr 13, 2022
@inpati @umagmrit
update zm-ews-stub jar version for zm-zcs-lib repo (#88)
8ce6562 
Squash and Merge changes for ZCS-4552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BhavinBathani BhavinBathani BhavinBathani approved these changes

@zimsuchitgupta zimsuchitgupta zimsuchitgupta approved these changes

@dasiyogesh dasiyogesh dasiyogesh approved these changes

@shrutig0510 shrutig0510 shrutig0510 approved these changes

@dawoodshaikh dawoodshaikh Awaiting requested review from dawoodshaikh

@preshitaagrawal preshitaagrawal Awaiting requested review from preshitaagrawal

@umagmrit umagmrit Awaiting requested review from umagmrit

@abhishekdeshmukh2209 abhishekdeshmukh2209 Awaiting requested review from abhishekdeshmukh2209

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@inpati @CLAassistant @BhavinBathani @zimsuchitgupta @dasiyogesh @shrutig0510